Mir

Code review comment for lp:~mir-team/mir/unify-pointer-button

  1. unify-pointer-button
  2. Merge into development-branch
Revision history for this message
Kevin DuBois (kdub) wrote :

nonblocking comment:
The bitmask seems okay for now, plenty of unused bits left.

needs-info
77+ mev.button_state[mir_pointer_button_tertiary] = true;

Since this appears private now, could we have something more like:
mev.button_state[mir_pointer_button_tertiary] = pressed;
It took a bit of reading of the struct to figure out what was going on in the present form.

review: Needs Information

« Back to merge proposal