Mir

Code review comment for lp:~mir-team/mir/unify-pointer-button

  1. unify-pointer-button
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Seems self-consistent.

But I'm a little concerned that other APIs treat buttons as bitmasks (e.g. "143+ android_state |= AMOTION_EVENT_BUTTON_PRIMARY;"). Apart from not matching expectations are we really sure we know better?

review: Needs Information

« Back to merge proposal