Mir

Code review comment for lp:~mir-team/mir/unify-keyboard-actions

  1. unify-keyboard-actions
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

218+int32_t android_keyboard_action_from_mir(MirKeyboardAction action, int32_t& repeat_count_out);

The name doesn't make it obvious that we have a return value and an out parameter - which, BTW is in the wrong location:

 http://unity.ubuntu.com/mir/cppguide/index.html?showone=Function_Parameter_Ordering#Function_Parameter_Ordering

review: Needs Fixing

« Back to merge proposal