Mir

Code review comment for lp:~mir-team/mir/unify-event-modifiers

Revision history for this message
Robert Carr (robertcarr) wrote :

>> I think that mir_input_event_modifier_none not being equal to 0 (i.e. no modifiers), makes its
>> use unintuitive, but that's another discussion.

Yeah you may be right. It was originally an intentional decision with the idea that 0 was reserved for an out of band/invalid state. Practically though I made an error in the original assembly of the branch (fixed before submission don't worry ;))...I'm not sure if it was just because of confusion with the android flags or this interface really is hard to use though.

« Back to merge proposal