Mir

Code review comment for lp:~mir-team/mir/touchspot-visualizer

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Forgive me for not understanding anything that ends in "...Controller". That still doesn't fit my mental model of anything after all these years. :(

"If we had this "Touchscreen" interface to query the list we would be set for direct mode but would need an additional notification interface" ...
Yeah I realized that in my last comment on 2014-07-08. I guess it's not terrible for those three features to trigger redraws via different interfaces. But maybe not ideal either.

I might propose some changes that would aid in reducing the redundant structs concern I raised on 2014-07-07. I'll say "Needs fixing" based on that still. Also...

(2) The name "TouchVisualizer" feels sub-optimal even as a notification interface. The first reason is that it sounds like something independent of the compositor, but couldn't be if it's visualizing. On the other hand, if you generalized the name to not involve rendering at all (like "TouchObserver") then that's solved.

review: Needs Fixing

« Back to merge proposal