Mir

Code review comment for lp:~mir-team/mir/touchspot-renderable

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

1362 + void move_to(geom::Point pos)
1363 + {
1364 + std::lock_guard<std::mutex> lg(guard);
1365 + position = pos;
1366 + }

The position should either represent the centroid of the buffer, or it should be translated so that the renderable position centroid is the position given.

Othewise, the touchspots look like they are offset from the touch location.

review: Needs Fixing

« Back to merge proposal