Code review comment for lp:~mir-team/mir/touchspot-renderable
Revision history for this message
| Robert Carr (robertcarr) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
kdub 1. Fixed rvalue usage...still not used to move semantics I guess.
2. Aha good call
3. It seems like we really need a Pixels(Array, Size, PixelFormat) kind of type...not for this MP though I think.
4, 5: Good call.
6: Hmm I kind of have the thought that I like it more this way so people can just construct it without getting in to the game of who owns the dependencies. On the other hand its not clear that hiding the depdency in the constructor is really correct. I think you could make an argument for it though in that the gralloc module is effectively a system resource...*shrug* I dont have a strong enough opinion to change it really but maybe someone else will comment.
7, 8: Fixed
9: I've thought about it...the problem is effective circle anti-aliasing algorithms are more than a few dozen that lines long...at which point the question starts to become, should we link in pixman? etc...to which there has been a little resistance in the past so I didn't want to dredge up again.