Code review comment for lp:~mir-team/mir/touchspot-renderable

(1) server-ABI-sha1sums: Changes to the ordering of this file are unreviewable (can't tell if things have been deleted or just moved). Please either keep the existing ordering or propose a re-ordering separately as a pre-req.

Proposed reoredering as prereq.

(3) Unused #includes and whitespace changes can be removed:
src/server/compositor/temporary_buffers.cpp
src/server/compositor/temporary_buffers.h

Fixed! Thanks.

>> (4) src/platform/graphics/android/android_buffer_writer.cpp
>> Hmm, I'm wondering if we should have already abstracted software buffers on the server side so you
>> don't need to write platform-specific code like this.

You mean something like a generic version of the mesa shm_buffer? At one point I was thinking about something like this...but this way should be faster on platforms like android with HWC which allow generic buffer overlay.