Mir

Code review comment for lp:~mir-team/mir/touchspot-renderable

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(3) Unused #includes and whitespace changes can be removed:
src/server/compositor/temporary_buffers.cpp
src/server/compositor/temporary_buffers.h

(4) src/platform/graphics/android/android_buffer_writer.cpp
Hmm, I'm wondering if we should have already abstracted software buffers on the server side so you don't need to write platform-specific code like this.

(5) A touchspot size of 64px is probably too small for high-res displays. If you're actually touching the display then it would be helpful for the touchspot to not be so small that it's completely hidden behind a finger. Consider making the Renderable rectangle dimensions independent of the buffer dimensions. OpenGL will scale for you.

« Back to merge proposal