Mir

Code review comment for lp:~mir-team/mir/touchspot-renderable

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

At a quick glance, the things making this a 3685 line proposal actually don't need to be here...

(1) server-ABI-sha1sums: Changes to the ordering of this file are unreviewable (can't tell if things have been deleted or just moved). Please either keep the existing ordering or propose a re-ordering separately as a pre-req.

(2) touchspot_image.c: Obviously big as text. I think we can do better by generating this texture algorithmically. Not a blocker but I might do a proof-of-concept to demonstrate...

review: Needs Fixing

« Back to merge proposal