623 + catch (std::runtime_error const& err)
Why not std::exception?
=== 2903 +++ tools/install_on_android.sh 2015-01-21 10:31:54 +0000 2904 @@ -32,11 +32,11 @@ 2905 lib/libmirclient.so.* \ 2906 lib/libmircommon.so.* \ 2907 lib/libmirplatform.so.* \ 2908 - lib/libmirplatform*driver.so \ 2909 - lib/libmirclient*driver.so \ 2910 + lib/platform-graphics-dummy.so \ 2911 + lib/client-modules/* \ 2912 + lib/server-modules/* \ 2913 lib/libmirprotobuf.so.* \ 2914 lib/libmirclient-debug-extension.so.* \ 2915 - lib/libmirplatformstub.so \ 2916 lib/libmirserver.so.* ===
Needs more modifications to work, given the current wrapper (i.e. copying the .mir_xxx executables and creating a bin and lib directory on the android side. But it looks like that's a pre-existing issue and is being addressed in https://code.launchpad.net/~andreas-pokorny/mir/unwrap-the-wrap/+merge/247117
Looks good otherwise.
« Back to merge proposal
623 + catch (std::runtime_error const& err)
Why not std::exception?
=== on_android. sh 2015-01-21 10:31:54 +0000 t.so.* \ n.so.* \ orm.so. * \ orm*driver. so \ t*driver. so \ graphics- dummy.so \ modules/ * \ modules/ * \ buf.so. * \ t-debug- extension. so.* \ ormstub. so \ r.so.*
2903 +++ tools/install_
2904 @@ -32,11 +32,11 @@
2905 lib/libmirclien
2906 lib/libmircommo
2907 lib/libmirplatf
2908 - lib/libmirplatf
2909 - lib/libmirclien
2910 + lib/platform-
2911 + lib/client-
2912 + lib/server-
2913 lib/libmirproto
2914 lib/libmirclien
2915 - lib/libmirplatf
2916 lib/libmirserve
===
Needs more modifications to work, given the current wrapper (i.e. copying the .mir_xxx executables and creating a bin and lib directory on the android side. But it looks like that's a pre-existing issue and is being addressed in https:/ /code.launchpad .net/~andreas- pokorny/ mir/unwrap- the-wrap/ +merge/ 247117
Looks good otherwise.