Mir

Code review comment for lp:~mir-team/mir/server-platform-probing

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hm. I think that SharedLibraryProbeReport is a mistake.

I had it in the client platform because we currently have no way to log from the client, but on the server it really just wants to be logged.

I now think the correct solution is to add logging support to the client library and then log everywhere. For a temporary fix, I think it'd be OK to default to log_opt_value rather than none_opt_value.

Otherwise (unsurprisingly!) +1.

review: Needs Fixing

« Back to merge proposal