Mir

Merge lp:~mir-team/mir/repair-client-abi into lp:mir

Proposed by Robert Carr
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 2311
Proposed branch: lp:~mir-team/mir/repair-client-abi
Merge into: lp:mir
Diff against target: 105 lines (+40/-6)
3 files modified
src/client/mir_connection_api.cpp (+27/-4)
src/client/symbols-debug.map (+9/-1)
src/client/symbols.map (+4/-1)
To merge this branch: bzr merge lp:~mir-team/mir/repair-client-abi
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Alexandros Frantzis (community) Approve
Daniel van Vugt Abstain
Chris Halse Rogers Approve
Review via email: mp+248899@code.launchpad.net

Commit message

Repair client ABI

Description of the change

Repair client ABI

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

/usr/bin/ld: ../../lib/libmirclient-debug-extension.so.1: version node not found for symbol mir_connection_platform_operation@MIR_CLIENT_8
/usr/bin/ld: failed to set dynamic section sizes: Bad value
collect2: error: ld returned 1 exit status

review: Needs Fixing
Revision history for this message
Chris Halse Rogers (raof) wrote :

Now good.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Abstain
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

6 - * Copyright © 2014 Canonical Ltd.
7 + * Copyright © 2015 Canonical Ltd.

Shouldn't that be 2014-2015 (or 2014,2015)?

review: Needs Fixing
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

As noted in https://code.launchpad.net/~afrantzis/mir/platform-operation-client-api-remove-opcode/+merge/248338 :

"This is a client API/ABI break, but since the platform operation API is not currently used by external code (and could not have been used because we didn't expose any operations), we can get away with it."

However, since this fix has already landed independently on 0.11, it's good to be in sync.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

okay, with copyright date update, and removal in next soname bump

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/client/mir_connection_api.cpp'
--- src/client/mir_connection_api.cpp 2015-02-04 15:01:59 +0000
+++ src/client/mir_connection_api.cpp 2015-02-09 21:38:34 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright © 2014 Canonical Ltd.2 * Copyright © 2014,2015 Canonical Ltd.
3 *3 *
4 * This program is free software: you can redistribute it and/or modify it4 * This program is free software: you can redistribute it and/or modify it
5 * under the terms of the GNU Lesser General Public License version 3,5 * under the terms of the GNU Lesser General Public License version 3,
@@ -305,7 +305,20 @@
305 connection->available_surface_formats(formats, format_size, *num_valid_formats);305 connection->available_surface_formats(formats, format_size, *num_valid_formats);
306}306}
307307
308MirWaitHandle* mir_connection_platform_operation(308extern "C"
309{
310MirWaitHandle* new_mir_connection_platform_operation(
311 MirConnection* connection,
312 MirPlatformMessage const* request,
313 mir_platform_operation_callback callback, void* context);
314MirWaitHandle* old_mir_connection_platform_operation(
315 MirConnection* connection, int /* opcode */,
316 MirPlatformMessage const* request,
317 mir_platform_operation_callback callback, void* context);
318}
319
320__asm__(".symver new_mir_connection_platform_operation,mir_connection_platform_operation@@MIR_CLIENT_8.3");
321MirWaitHandle* new_mir_connection_platform_operation(
309 MirConnection* connection,322 MirConnection* connection,
310 MirPlatformMessage const* request,323 MirPlatformMessage const* request,
311 mir_platform_operation_callback callback, void* context)324 mir_platform_operation_callback callback, void* context)
@@ -322,6 +335,16 @@
322335
323}336}
324337
338// TODO: Remove when we bump so name
339__asm__(".symver old_mir_connection_platform_operation,mir_connection_platform_operation@MIR_CLIENT_8");
340MirWaitHandle* old_mir_connection_platform_operation(
341 MirConnection* connection, int /* opcode */,
342 MirPlatformMessage const* request,
343 mir_platform_operation_callback callback, void* context)
344{
345 return new_mir_connection_platform_operation(connection, request, callback, context);
346}
347
325/**************************348/**************************
326 * DRM specific functions *349 * DRM specific functions *
327 **************************/350 **************************/
@@ -390,7 +413,7 @@
390413
391 mir_platform_message_set_data(msg.get(), &request, sizeof(request));414 mir_platform_message_set_data(msg.get(), &request, sizeof(request));
392415
393 return mir_connection_platform_operation(416 return new_mir_connection_platform_operation(
394 connection,417 connection,
395 msg.get(),418 msg.get(),
396 platform_operation_to_auth_magic_callback,419 platform_operation_to_auth_magic_callback,
@@ -411,7 +434,7 @@
411 static int const success{0};434 static int const success{0};
412 int status{-1};435 int status{-1};
413436
414 auto wh = mir_connection_platform_operation(437 auto wh = new_mir_connection_platform_operation(
415 connection,438 connection,
416 msg.get(),439 msg.get(),
417 assign_set_gbm_device_status,440 assign_set_gbm_device_status,
418441
=== modified file 'src/client/symbols-debug.map'
--- src/client/symbols-debug.map 2014-08-14 05:03:46 +0000
+++ src/client/symbols-debug.map 2015-02-09 21:38:34 +0000
@@ -1,5 +1,13 @@
1{1MIR_CLIENT_DEBUG_8 {
2 global: 2 global:
3 mir_debug_*;3 mir_debug_*;
4 local: *;4 local: *;
5};5};
6
7MIR_CLIENT_8 {
8 local: mir_connection_platform_operation;
9};
10
11MIR_CLIENT_8.3 {
12 local: mir_connection_platform_operation;
13};
614
=== modified file 'src/client/symbols.map'
--- src/client/symbols.map 2015-02-04 13:56:37 +0000
+++ src/client/symbols.map 2015-02-09 21:38:34 +0000
@@ -1,5 +1,7 @@
1MIR_CLIENT_8 {1MIR_CLIENT_8 {
2 global: mir_*;2 global:
3 mir_connection_platform_operation;
4 mir_*;
3 extern "C++" { 5 extern "C++" {
4 # used by PrivateProtobuf6 # used by PrivateProtobuf
5 mir::client::the_rpc_channel*;7 mir::client::the_rpc_channel*;
@@ -40,4 +42,5 @@
40 mir_connection_create_spec_for_menu;42 mir_connection_create_spec_for_menu;
41 mir_connection_create_spec_for_tooltip;43 mir_connection_create_spec_for_tooltip;
42 mir_connection_create_spec_for_dialog;44 mir_connection_create_spec_for_dialog;
45 mir_connection_platform_operation;
43} MIR_CLIENT_8.2;46} MIR_CLIENT_8.2;

Subscribers

People subscribed via source and target branches