Mir

Code review comment for lp:~mir-team/mir/remove-global-constructor-socket

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'm not sure this is well motivated.

The test case that triggers the issue this addresses is one that can hardly be described as a "unit test". The only reason I can see for adding it to that binary is the use of umockdev (and that usage for *unit* tests is already controversial).

The unit tests already statically link a *lot* of the contents of libmircommon and this leads to ODR violations.

« Back to merge proposal