Code review comment for lp:~mir-team/mir/reduce-event-pedantism-for-1437357
Revision history for this message
| Robert Carr (robertcarr) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
>> Where does the problem originate? In our "adopted" input code or outside our control?
>>
>> I think "error" is an overreaction and "warning" would be better as it doesn't threaten
>> functionality. (Especially if the cause is outside our control.)
I'm not entirely sure yet. It seems the problem can both originate from a broken kernel event stream, or from bugs which cause the InputReader to malform what should have been a functioning input stream...thus I'm not inclined to say it's out of our control.
It actually does threaten functionality...if multiple up downs are encoded in one event the android action masking format will end up erasing some of the actions...I guess this would result in "quirky touch" depending on how valid an input stream the client requires. On the other hand this was apparently always happening and touch has been working pretty well though QtMir had to have a validator of course.