Mir

Code review comment for lp:~mir-team/mir/public-cookie-api

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+ * NULL will be returned if the buffer and size dont describe

s/dont/don't/

~~~~

+ * Construction function used to create a Authority. The secret size must be

s/a Authority/an Authority/

~~~~

+ // TODO Soon to be removed!
+ static std::unique_ptr<Authority> create_saving(Secret& save_secret);

Why?

~~~~

 /// Sets an override functor for creating the cookie factory.

s/factory/authority/

~~~~

+ mir::cookie::Blob copy_vector_to_cookie_blob(std::vector<uint8_t> const& vector)

It's local to the TU, so I wouldn't block, but I'd reserve "copy" for functions that take a target. I'd call it something like "as_blob".

review: Needs Fixing

« Back to merge proposal