+ * NULL will be returned if the buffer and size dont describe
s/dont/don't/
~~~~
+ * Construction function used to create a Authority. The secret size must be
s/a Authority/an Authority/
+ // TODO Soon to be removed! + static std::unique_ptr<Authority> create_saving(Secret& save_secret);
Why?
/// Sets an override functor for creating the cookie factory.
s/factory/authority/
+ mir::cookie::Blob copy_vector_to_cookie_blob(std::vector<uint8_t> const& vector)
It's local to the TU, so I wouldn't block, but I'd reserve "copy" for functions that take a target. I'd call it something like "as_blob".
« Back to merge proposal
+ * NULL will be returned if the buffer and size dont describe
s/dont/don't/
~~~~
+ * Construction function used to create a Authority. The secret size must be
s/a Authority/an Authority/
~~~~
+ // TODO Soon to be removed! ptr<Authority> create_ saving( Secret& save_secret);
+ static std::unique_
Why?
~~~~
/// Sets an override functor for creating the cookie factory.
s/factory/ authority/
~~~~
+ mir::cookie::Blob copy_vector_ to_cookie_ blob(std: :vector< uint8_t> const& vector)
It's local to the TU, so I wouldn't block, but I'd reserve "copy" for functions that take a target. I'd call it something like "as_blob".