Mir

Code review comment for lp:~mir-team/mir/public-cookie-api

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

A first pass:

+ static std::unique_ptr<Authority> create_saving(Secret& save_secret);

The name 'create_saving' is not very clear.

+ std::copy_n(std::begin(cookie), cookie.size(), std::begin(kev.cookie));

The code as written could overflow the kev.cookie array.

+#include "../mir_cookie.h"

We generally try to avoid pulling headers from parent directories (but it's not a dealbreaker, and it seems we are doing it more on the client side).

review: Needs Fixing

« Back to merge proposal