A first pass:
+ static std::unique_ptr<Authority> create_saving(Secret& save_secret);
The name 'create_saving' is not very clear.
+ std::copy_n(std::begin(cookie), cookie.size(), std::begin(kev.cookie));
The code as written could overflow the kev.cookie array.
+#include "../mir_cookie.h"
We generally try to avoid pulling headers from parent directories (but it's not a dealbreaker, and it seems we are doing it more on the client side).
« Back to merge proposal
A first pass:
+ static std::unique_ ptr<Authority> create_ saving( Secret& save_secret);
The name 'create_saving' is not very clear.
+ std::copy_ n(std:: begin(cookie) , cookie.size(), std::begin( kev.cookie) );
The code as written could overflow the kev.cookie array.
+#include "../mir_cookie.h"
We generally try to avoid pulling headers from parent directories (but it's not a dealbreaker, and it seems we are doing it more on the client side).