Mir

Code review comment for lp:~mir-team/mir/public-cookie-api

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

From what I see at the ClientCookies fixture. The test body does not wait for the client surface to be exposed and focused. So there is a chance that the SurfaceInputDispatcher does not forward the event to the client. I.e. you could cut some code out of the TestClientInput fixture. CI does not seem to affected by that problem, so you might as well do that some time after the release.

Is there a reason why you do not throw SecurityCheckErrors with BOOST_THROW_EXCEPTION?

review: Needs Information

« Back to merge proposal