Mir

Code review comment for lp:~mir-team/mir/public-cookie-api

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Oops on the last one I meant:

---
void mir_cookie_copy_to_buffer(MirCookie const* cookie, void* buffer, size_t size)
{
    mir::require(size == mir::cookie::array_size);
    memcpy(buffer, cookie, size);
}
---

With a client side MirCookie class suggested above would just become:
void mir_cookie_copy_to_buffer(MirCookie const* cookie, void* buffer, size_t size)
{
    return cookie->copy_to(buffer, size);
}

and mir_cookie_release turns into:

+void mir_cookie_release(MirCookie const* cookie)
{
    delete cookie;
}

review: Needs Fixing

« Back to merge proposal