> > > + virtual bool attest_timestamp(MirCookie const* cookie) = 0;
> > >
> > > This is the only place in the interface MirCookie is mentioned. Should we
> > > simply lose this function and require the user to call the other overload?
> > >
> > > ~~~~
> >
> > The reason for keeping this, is theres no way to de construct a MirCookie in
> > the public. So once the content hub gets a mir cookie it wont know how to
> > *attest* it.
>
> are you conflating ::MirCookie and mir::cookie::MirCookie?
Well only mir::cookie::MirCookie should be used? The attest_timestamp is in the mir::cookie namespace. Not sure if they are different and being combined? I Could be wrong :)
> > > + virtual bool attest_ timestamp( MirCookie const* cookie) = 0; :MirCookie?
> > >
> > > This is the only place in the interface MirCookie is mentioned. Should we
> > > simply lose this function and require the user to call the other overload?
> > >
> > > ~~~~
> >
> > The reason for keeping this, is theres no way to de construct a MirCookie in
> > the public. So once the content hub gets a mir cookie it wont know how to
> > *attest* it.
>
> are you conflating ::MirCookie and mir::cookie:
Well only mir::cookie: :MirCookie should be used? The attest_timestamp is in the mir::cookie namespace. Not sure if they are different and being combined? I Could be wrong :)