Mir

Code review comment for lp:~mir-team/mir/public-cookie-api

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > + virtual bool attest_timestamp(MirCookie const* cookie) = 0;
> >
> > This is the only place in the interface MirCookie is mentioned. Should we
> > simply lose this function and require the user to call the other overload?
> >
> > ~~~~
>
> The reason for keeping this, is theres no way to de construct a MirCookie in
> the public. So once the content hub gets a mir cookie it wont know how to
> *attest* it.

are you conflating ::MirCookie and mir::cookie::MirCookie?

« Back to merge proposal