Mir

Code review comment for lp:~mir-team/mir/public-cookie-api

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

> + typedef struct MirCookie MirCookie;
>
> Not needed (at the moment at least), and also may conflict with
> mir::cookie::MirCookie.

Opps thought I removed all thoses... Had an idea at one point that I think made it into a file :)
>
> - virtual MirCookie timestamp_to_cookie(uint64_t const& timestamp) = 0;
>
> A *Cookie*Factory that doesn't create cookies seems strange.
>
> Needs discussion/fixing

Right it doesnt create any MirCookies but it creates what a cookie is. With alans comment, changing the name to:
CookieAuthority

« Back to merge proposal