Mir

Code review comment for lp:~mir-team/mir/introduce-pointer-event

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This distinction is confusing:

306 +// Differentiate between MirTouchInputEvents and MirPointerInputEvents based on old device class
307 +MirInputEventType type_from_device_class(int32_t source_class)
308 +{
309 + switch (source_class)
310 + {
311 + case AINPUT_SOURCE_MOUSE:
312 + case AINPUT_SOURCE_TRACKBALL:
313 + case AINPUT_SOURCE_TOUCHPAD:
314 + return mir_input_event_type_pointer;
315 + // Realistically touch events should only come from Stylus and Touchscreen
316 + // device classes...practically its not clear this is a safe assumption.
317 + default:
318 + return mir_input_event_type_touch;
319 + }
320 +}

If "pointer" events don't include the pointiest kind of input (stylus, finger) then we need to clarify the terminology. Perhaps:
   MirAbsoluteInputEvent (stylus, finger)
   MirRelativeInputEvent (mouse, trackball, touchpad)
   MirFocussedInputEvent (keyboard and other buttons)

review: Needs Fixing

« Back to merge proposal