Code review comment for lp:~mir-team/mir/introduce-mir-event-2.0

Thanks :D

>> This function is not input specific so it should be elsewhere (not in input_event.h). E.g. it >> be odd to have to include input_event.h in your app if you were looking for, say,
>> 'mir_event_type_prompt_session_state_change'.

Indeed. Fixed.

>> 637 +MirEventType mir_event_get_type(MirEvent const* ev)

>> This one also looks out of place as it's not input specific, yet it's defined in
>> input_event.cpp.

Yes but I dont think its worth creating event.cpp until there is other stuff in there.

Nits :

>> Do we want some masks for MirKeyInputEventModifiers.

I don't think so, as I mentioned in standup, I think in the future we will move to using opaque modifier masks from strings anyway.
_________________________

>> 883 + case mir_motion_tool_type_mouse:
>> Not sure why 'mouse' should return 'unknown'.

Because mir_motion_tool_type_mouse does not have an equivalent in the MirEvent 2.0 world. Or rather at least, mouse is not a touch tool, and will generate a separate pointer event category (not defined in this mp).This at least doesn't regress pointer support anywhere though (though already its quite flakey...)