Code review comment for lp:~mir-team/mir/introduce-mir-event-2.0

Needs fixing :

216 +MirEventType mir_event_get_type(MirEvent const* ev);

This function is not input specific so it should be elsewhere (not in input_event.h). E.g. it 'd be odd to have to include input_event.h in your app if you were looking for, say, 'mir_event_type_prompt_session_state_change'.
_______________________

637 +MirEventType mir_event_get_type(MirEvent const* ev)

This one also looks out of place as it's not input specific, yet it's defined in input_event.cpp.
_______________________

Nits :

Do we want some masks for MirKeyInputEventModifiers. E.g. mir_key_input_event_modifier_alt_mask = mir_key_input_event_modifier_alt |mir_key_input_event_modifier_alt_left | mir_key_input_event_modifier_alt_right;

_______________________

old_modifiers_to_new could be made more efficient by using masks.

_________________________

883 + case mir_motion_tool_type_mouse:

Not sure why 'mouse' should return 'unknown'.