Mir

Code review comment for lp:~mir-team/mir/improve-attribute-protocol-and-normalize-getters

  1. improve-attribute-protocol-and-normalize-getters
  2. Merge into development-branch
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

Nit:
260 + std::lock_guard<std::mutex> lg(guard);

As mentioned by Daniel, locking is not currently needed.

review: Approve

« Back to merge proposal