Code review comment for lp:~mir-team/mir/fix-1475571

Yeah, fair enough. If gbm_bo_create doesn't return a scanoutable buffer when asked to provide one that's probably a gbm bug.

26 +TEST_F(MesaBufferAllocatorTest, is_format_supported_not_called)
should just be removed. We don't need to test that we don't call a function. It's a duplicate of the throws_on_buffer_creation_failure test a couple of tests up.

If you really want to test something, test that buffer allocation succeeds even if gbm_device_is_format_supported returns false. I don't think that's particularly necessary, though.