Mir

Code review comment for lp:~mir-team/mir/expose-debug-buffer-id-to-client

  1. expose-debug-buffer-id-to-client
  2. Merge into trunk
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Wow, seems I'm the blocker here. Just a few issues:

1. DEPRECATED should use proper Doxygen: \deprecated

2. Lines too long; need wrapping before col 80:
include/client/mir_toolkit/mir_client_library_debug.h

3. Should be const:
86 + uint32_t current_buffer_id();

Overall I think the line between "debug" and regular client API is still too blurry. But I can't think of a way to make it clearer right now. So just worry about the above nitpicks.

review: Needs Fixing

« Back to merge proposal