> (1) If the client library isn't guaranteeing this is cleaned up atexit for all
> clients already, I think it should. That's better than having to remember to
Without this MP we require clients to release connections before the end of main().
We have one client (platform-api) that releases a connection after main() exits.
This MP adds support for the way that client behaves.
All client side resources are released when the process exits. The server will detect the dead socket and releases resources corresponding in that process. What further cleanup are you suggesting is needed?
> reimplement the same in every client...
>
> 26 + // We should always release our connection
> 27 + atexit(&close_connection);
Yes, maybe I should put the example back the way it was - this is not the canonical way to implement a client.
> (1) If the client library isn't guaranteeing this is cleaned up atexit for all
> clients already, I think it should. That's better than having to remember to
Without this MP we require clients to release connections before the end of main().
We have one client (platform-api) that releases a connection after main() exits.
This MP adds support for the way that client behaves.
All client side resources are released when the process exits. The server will detect the dead socket and releases resources corresponding in that process. What further cleanup are you suggesting is needed?
> reimplement the same in every client... &close_ connection) ;
>
> 26 + // We should always release our connection
> 27 + atexit(
Yes, maybe I should put the example back the way it was - this is not the canonical way to implement a client.