Mir

Code review comment for lp:~mir-team/mir/enable-dynamic-buffer-queue

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(8) I just added some printfs and the code is actually still triple buffering on bypass (mostly but not always). If you're not seeing that behaviour then try:
    mir_demo_client_egltriangle -f
and Ctrl+Alt+arrows to rotate a few times (force compositing) before going back to bypass (Ctrl+Alt+Up).

So either:
  (a) that old behaviour is still correct and you need to reinstate tests for it like bypass_clients_get_more_than_two_buffers; or
  (b) it shouldn't be triple buffering bypass clients and it's a bug; or
  (c) it's just bad timing in the wrong phase and sometimes really does need 3 buffers to keep up.

It looks like the bypass detection code is still present and that's what's pushing it up to 3:
  increase_demand = multiple_compositor_buffers

« Back to merge proposal