Mir

Code review comment for lp:~mir-team/mir/enable-dynamic-buffer-queue

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> > 85 + bool use_current_buffer = force_use_current_buffer;
> >
> > How about replacing the current logic (which has become a bit complex) with
> > something more straightforward (IMO) like:
>
> Actually, what I proposed above probably doesn't work, but the point is that
> we should try to simplify the paths in that function since it has become too
> complex.

But this version seems to work (at least it passes all the tests):

bool const use_current_buffer =
    force_use_current_buffer ||
    current_buffer_is_used_but_not_by(user_id) ||
    !have_new_compositor_buffer();

« Back to merge proposal