Code review comment for lp:~mir-team/mir/cursor-spike-phase-2-resubmit
Revision history for this message
| Robert Carr (robertcarr) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Fixed indentation, verbose and TODOs. Though, the branch removing the TODOs (which now has to be updated to remove the TODOs) is ready to propose when this one lands ;)
>> Is a comment really clearer than a boolean field?
In this case I think it is. If you use a field there are two more questions:
What if the enabled field is true but there is no cursor image?
What if the enabled field is false but there is a cursor image?
Not only are there multiple possible behaviors but it requires documentation as well.
>> Also with this and other tests it looks like a lot of the setup could be moved into the test fixture -
>> which would make toe behavior under test a lot clearer.
I'll do another round of abstraction on the tests once I have a little more time to deal with the input tests as well and arrive at the grand unified input test fixture.