Mir

Code review comment for lp:~mir-team/mir/cursor-spike-phase-2-resubmit

Revision history for this message
Robert Carr (robertcarr) wrote :

Thanks!

>> We submit the cursor and the surface, but don't tell what we want (I assume its like "make an hourglass
>> over this surface", or "hide cursor over this surface"). Is a 3rd parameter coming in the future?

MirCursor was in fact this struct. I've renamed it to MirCursorConfiguration to be more explicit.

>> 2) is it difficult to add a mir_available_cursor_names() sort of function, so we know what strings will get >> a cursor? this could condense the 'default' and 'disabled' cursor acquisition too.

I'll add this with the loader.

>> 3) MirCursor is c++ code, why not std::string?
>> 4) include guards on cursor_representation.h

Fixed!

« Back to merge proposal