Mir

Code review comment for lp:~mir-team/mir/cursor-spike-phase-1-resubmit-resubmit-resubmit-hello-out-there

Revision history for this message
Kevin DuBois (kdub) wrote :

I'll abstain, until I know more of the future plan in the area of cursors.

Some of the things are pre-existing.

I still think CursorImage is close to:
http://bazaar.launchpad.net/~mir-team/mir/development-branch/view/head:/src/server/scene/pixel_buffer.h

and that there's the pre-existing issue that android has no good way to implement
auto mga::AndroidDisplay::create_hardware_cursor

It makes more sense to me for a cursor buffer to be generated from the_buffer_allocator(). Android would just return any old buffer, mesa could return a sensibly-sized hardware cursor buffer.

shouldn't the destructor for CursorImage{,s} be public?

review: Abstain

« Back to merge proposal