Mir

Code review comment for lp:~mir-team/mir/consolidate-crossbuild-scripts

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm not going to spend time testing with the Nexus today so can't really declare this properly reviewed.

If I was to nit-pick then I would say try to avoid using "$1" more than once in a script. It is easier for maintenance and readability to use:
  foo="$1"
and then $foo thereafter.

I will trust the existing approvals are enough for now.

review: Abstain

« Back to merge proposal