Code review comment for lp:~mir-team/mir/client-api-deprecation

79 + * \note TODO: Cleanup remove callback?

Yes we should.
----------------------

+ *
139 + * \note May need deprecation - Need a consistent API for high DPI scaling/destination size
140 + *
141 * \param [in] buffer_stream The buffer stream
142 * \param [in] scale The scale
143 - * \return A handle that can be passed to mir_wait_for
144 + * \return A handle that can be passed to mir_wait_for
145 */
146 MirWaitHandle *mir_buffer_stream_set_scale(MirBufferStream* buffer_stream, float scale);

At least the wait handle needs to be done away with.
----------------------

479 + * \note There is no implicit buffer stream creation. See mir_xxx to attach content.

You mean the "default" buffer stream.

Also, it should read "mir_surface_spec_add_render_surface() to attach content".
----------------------

488 + * \deprecated No replacement. This property is now part of the backing content
...

503 + * \deprecated No replacement. This property is now part of the backing content

More precisely, there is no default stream backing the surface.
----------------------