Mir

Code review comment for lp:~mir-team/mir/alternative-extension-naming

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hm, I like the cut of your jib!

static inline foo_v1_extensions const* request_foo_v1(MirConnection* connection)
{
    return mir_connection_request_extension(connection, "mir_foo", 1);
}

Relevant changes: pass in the MirConnection, because that's the object that knows about extensions. Return a pointer-to-const rather than populating an input pointer so that the extension table can live in the RO .text section and we can have a single table for all versions of the extension.

« Back to merge proposal