Code review comment for lp:~mir-team/mir/allow-lock-surf-orientation

Awaiting final version for review. For now I have the following nits :

It'd make sense to base this MP on ~vanvugt/mir/named-attrib-values
---------------------------
82 + mir_permitted_orientation_all = mir_permitted_orientation_normal |
83 + mir_permitted_orientation_left |
84 + mir_permitted_orientation_right |
85 + mir_permitted_orientation_inverted,
Would make more sense if mir_permitted_orientation_all were at the end.
---------------------------
180 + MirPermittedOrientations perm_orientations = mir_permitted_orientation_all;
Would it not make more sense to restrict the client to something like mir_permitted_orientation_normal if this function were to throw?