Code review comment for lp:~mir-team/mir/add-more-event-getters

475 === added file 'include/common/mir_toolkit/events/event_private.h'

It seems odd to call a public header "private" and also to include it include/common/mir_toolkit/events/event.h.

I assume it is there to support the deprecated API? And will move from the public API once downstream toolkits have had the opportunity to migrate?

~~~~

1636 if(touch_index > old_mev.pointer_count)
1637 + {
1638 + mir::log_critical("touch index is greater than pointer count");
1639 abort();
1640 + }
etc.

This if...log...abort pattern calls out to be formalized - either as a mir::require() function (or maybe a MIR_REQUIRE macro if we feel that __LINE__ and __FILE__ could be useful additions).