Mir

Code review comment for lp:~mir-team/mir/add-more-event-getters

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

> Cemil: At l 93 that's the correct spelling of retrieve right? This line is
> gone now anyway but I believe the spellings to be correct...

It was the "wih" but is now gone.

>
> I believe abort with no error is the current strategy as discussed in
> introduce-event-2.0 MR + email thread. Maybe logging is appropriate?

Yes abort is ok, just wish there was a semi-useful log message to go with it.

« Back to merge proposal