Mir

Code review comment for lp:mir/0.21

  1. 0.21
  2. Merge into ubuntu
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Nice work on the 'unbreak' effort.

Unfortunately I just noticed another one. The changelog incorrectly states:

   mirclientplatform ABI unchanged at 4

but actually we did break it:

   CMakeLists.txt:set(MIR_CLIENT_PLATFORM_ABI 5)

So either it's a serious break and needs unbreaking, or it's a break we can live with and just the changelog needs correcting.

review: Needs Fixing

« Back to merge proposal