Mir

Code review comment for lp:mir/0.11

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems to me like there is a mir-client-platform-android-dev package missing, given that there is mir-client-platform-mesa-dev.

Also, I see debian/changelog doesn't list the changes to packages provided aside from the ABI changes; I think those and the relevant changes to debian/rules should be listed as well.

Finally, this is a rather big changeset, I'd feel much more confident if it could go through review from the usual trainguards too, since I haven't dealt with Mir updates for almost a year and I remember there are a few details that needed to be followed when publishing it.

Has the upgrade path been tested using the PPA to make sure packages update themselves safely on all types of devices (mesa and android) ?

review: Needs Information

« Back to merge proposal