Code review comment for ~minagalic/cloud-init:feax/ephemeral_connectivity

Revision history for this message
Chad Smith (chad.smith) wrote :

Here is a patch with some unit test cleanup and unit test adds for the new function you added.

I also adding a bit of checking on the url param passed to has_url_connectivity function since we don't want callsites to stuff in the wrong type of content.

Unit test adds and functionality changes below
http://paste.ubuntu.com/p/PQkjG6pHG8/

« Back to merge proposal