Code review comment for lp:~mims-michael/nuvola-player/bugfix1049253

Revision history for this message
Jiří Janoušek (fenryxo) wrote :

Thanks, Michael, for your work. I'm sorry for a late reply, but I have time for Nuvola Player only during weekends.

=== modified file 'data/nuvolaplayer/services/rdio/integration.js'
8 - Copyright 2012 Stefan Lohmaier <email address hidden>
9 + Copyright 2012 Michael Mims <email address hidden>

Did you rewrite this script from scratch? If not, you cannot remove Stefan's copyright.

-----8<------

=== modified file 'data/nuvolaplayer/services/rdio/integration.js'
36 + * client js side). See Nuvola bug #1049253.

Please use notation "LP:1049253".

-----8<------

=== modified file 'data/nuvolaplayer/services/rdio/metadata.conf'
178 version = 2
179 -version_minor = 4
180 -flash_plugin = no
181 +version_minor = 5

Increase version to 3.0 instead of 2.5.

review: Needs Fixing

« Back to merge proposal