Code review comment for lp:~milo/linaro-image-tools/bug1054422

Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, thanks for the nice fix.

However small the other fixes are, we should generally strive to keep them in separate branches, especially for things where we plan to do a last-minute re-rollout of the tarball: it would be much better to include only relevant changes (it's not going to be obvious what's going on in the commit log if you lump these three changes together, no matter how verbose you make the commit message; it's neither going to be clear why were the other two changes critical and that they needed a .1 release :).

review: Approve

« Back to merge proposal