Code review comment for lp:~milo/linaro-image-tools/bug1004199

Revision history for this message
Milo Casagrande (milo) wrote :

On Wed, Jun 13, 2012 at 3:33 PM, Данило Шеган <email address hidden> wrote:
>
> Actually, we should simply use ceil, and get rid of the + 0.5 trick altogether.
>
> I.e.
>
>  real_size = _check_min_size(ceil(real_size / ROUND_IMAGE_TO) * ROUND_IMAGE_TO))

With latest push I removed the "round" function, keeping only the
"int" conversion here, instead of doing it in the return statement,
sice we will execute _check_min_size anyway with MIN_IMAGE_SIZE that
is an int.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal