Code review comment for lp:~mikey74/openlp/dvdplayerfix

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Hi Mike,

Thanks for your contribution! As per our merge criteria, you need a test in order for this to be merged into trunk. Also, you only added the fix to trunk, not to the 2.4 line, so if you wanted to see it in 2.4.6 then you'll need to backport these changes to the 2.4 branch.

See the following links for more information:

  http://wiki.openlp.org/Development:Workflow#Run_Tests_Locally
  http://wiki.openlp.org/Development:Unit_Tests

review: Needs Fixing

« Back to merge proposal