Code review comment for lp:~mikemc/unity-scope-click/log-improvements

Revision history for this message
dobey (dobey) wrote :

30 - Log.set_handler ("unity-scope-click", LogLevelFlags.LEVEL_MASK,
31 + Log.set_handler (null, LogLevelFlags.LEVEL_MASK,

I don't understand why you made this change. You want log messages from all the underlying libraries to go to the file too?

53 internal async Unity.Preview build_app_preview(Unity.ScopeResult result) {
54 + debug ("build_app_preview");
55 var app_id = result.metadata.get(METADATA_APP_ID).get_string();

Different spacing here on the added line.

review: Needs Fixing

« Back to merge proposal