Merge lp:~mikemc/ubuntuone-client/fix-1029636 into lp:ubuntuone-client

Proposed by Mike McCracken
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 1281
Merged at revision: 1281
Proposed branch: lp:~mikemc/ubuntuone-client/fix-1029636
Merge into: lp:ubuntuone-client
Diff against target: 80 lines (+6/-12)
5 files modified
bin/ubuntuone-syncdaemon (+4/-1)
tests/syncdaemon/test_eventqueue.py (+1/-1)
ubuntuone/platform/__init__.py (+0/-6)
ubuntuone/platform/filesystem_notifications/__init__.py (+0/-3)
ubuntuone/syncdaemon/event_queue.py (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-client/fix-1029636
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
dobey (community) Approve
Review via email: mp+117099@code.launchpad.net

Commit message

- Remove unnecessary symbol imports to avoid loading default reactor when not needed (LP: #1029636)

Description of the change

- Remove unnecessary symbol imports to avoid loading default reactor when not needed (LP: #1029636)

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

Great, we won't longer have problems with the wrong reactor being installed via the platform package.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubuntuone-syncdaemon'
--- bin/ubuntuone-syncdaemon 2012-07-17 10:51:43 +0000
+++ bin/ubuntuone-syncdaemon 2012-07-27 17:13:21 +0000
@@ -48,7 +48,6 @@
4848
49from ubuntuone.platform import (49from ubuntuone.platform import (
50 can_write,50 can_write,
51 get_filemonitor_class,
52 set_dir_readwrite,51 set_dir_readwrite,
53 is_already_running,52 is_already_running,
54 is_root,53 is_root,
@@ -57,6 +56,10 @@
57 recursive_move,56 recursive_move,
58 set_application_name,57 set_application_name,
59)58)
59from ubuntuone.platform.filesystem_notifications.monitor import (
60 get_filemonitor_class,
61)
62
60from ubuntuone.syncdaemon import logger, config63from ubuntuone.syncdaemon import logger, config
61from ubuntuone.syncdaemon.config import (64from ubuntuone.syncdaemon.config import (
62 get_config_files,65 get_config_files,
6366
=== modified file 'tests/syncdaemon/test_eventqueue.py'
--- tests/syncdaemon/test_eventqueue.py 2012-07-17 13:53:12 +0000
+++ tests/syncdaemon/test_eventqueue.py 2012-07-27 17:13:21 +0000
@@ -37,7 +37,7 @@
37from twisted.trial.unittest import TestCase37from twisted.trial.unittest import TestCase
3838
39from contrib.testing.testcase import BaseTwistedTestCase, FakeVolumeManager39from contrib.testing.testcase import BaseTwistedTestCase, FakeVolumeManager
40from ubuntuone.platform import FilesystemMonitor40from ubuntuone.platform.filesystem_notifications.monitor import FilesystemMonitor
41from ubuntuone.syncdaemon import (41from ubuntuone.syncdaemon import (
42 event_queue,42 event_queue,
43 filesystem_manager,43 filesystem_manager,
4444
=== modified file 'ubuntuone/platform/__init__.py'
--- ubuntuone/platform/__init__.py 2012-07-17 13:53:12 +0000
+++ ubuntuone/platform/__init__.py 2012-07-27 17:13:21 +0000
@@ -101,12 +101,6 @@
101stat_path = os_helper.stat_path101stat_path = os_helper.stat_path
102walk = os_helper.walk102walk = os_helper.walk
103103
104# From Monitor
105from ubuntuone.platform.filesystem_notifications import monitor
106
107get_filemonitor_class = monitor.get_filemonitor_class
108FilesystemMonitor = monitor.FilesystemMonitor
109
110# From Logger104# From Logger
111setup_filesystem_logging = logger.setup_filesystem_logging105setup_filesystem_logging = logger.setup_filesystem_logging
112get_filesystem_logger = logger.get_filesystem_logger106get_filesystem_logger = logger.get_filesystem_logger
113107
=== modified file 'ubuntuone/platform/filesystem_notifications/__init__.py'
--- ubuntuone/platform/filesystem_notifications/__init__.py 2012-07-17 10:51:43 +0000
+++ ubuntuone/platform/filesystem_notifications/__init__.py 2012-07-27 17:13:21 +0000
@@ -29,10 +29,7 @@
29"""File System Notification module."""29"""File System Notification module."""
3030
31from ubuntuone.platform.filesystem_notifications import (31from ubuntuone.platform.filesystem_notifications import (
32 monitor,
33 notify_processor,32 notify_processor,
34)33)
3534
36_GeneralINotifyProcessor = notify_processor.NotifyProcessor35_GeneralINotifyProcessor = notify_processor.NotifyProcessor
37FilesystemMonitor = monitor.FilesystemMonitor
38get_filemonitor_class = monitor.get_filemonitor_class
3936
=== modified file 'ubuntuone/syncdaemon/event_queue.py'
--- ubuntuone/syncdaemon/event_queue.py 2012-07-12 16:04:44 +0000
+++ ubuntuone/syncdaemon/event_queue.py 2012-07-27 17:13:21 +0000
@@ -38,7 +38,7 @@
38from twisted.internet import defer38from twisted.internet import defer
3939
40from ubuntuone.platform.os_helper import access40from ubuntuone.platform.os_helper import access
41from ubuntuone.platform.filesystem_notifications import FilesystemMonitor41from ubuntuone.platform.filesystem_notifications.monitor import FilesystemMonitor
4242
43# these are our internal events, what is inserted into the whole system43# these are our internal events, what is inserted into the whole system
44EVENTS = {44EVENTS = {

Subscribers

People subscribed via source and target branches