Merge lp:~mikemc/ubuntuone-client/fix-1029636 into lp:ubuntuone-client

Proposed by Mike McCracken
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 1281
Merged at revision: 1281
Proposed branch: lp:~mikemc/ubuntuone-client/fix-1029636
Merge into: lp:ubuntuone-client
Diff against target: 80 lines (+6/-12)
5 files modified
bin/ubuntuone-syncdaemon (+4/-1)
tests/syncdaemon/test_eventqueue.py (+1/-1)
ubuntuone/platform/__init__.py (+0/-6)
ubuntuone/platform/filesystem_notifications/__init__.py (+0/-3)
ubuntuone/syncdaemon/event_queue.py (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-client/fix-1029636
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
dobey (community) Approve
Review via email: mp+117099@code.launchpad.net

Commit message

- Remove unnecessary symbol imports to avoid loading default reactor when not needed (LP: #1029636)

Description of the change

- Remove unnecessary symbol imports to avoid loading default reactor when not needed (LP: #1029636)

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

Great, we won't longer have problems with the wrong reactor being installed via the platform package.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntuone-syncdaemon'
2--- bin/ubuntuone-syncdaemon 2012-07-17 10:51:43 +0000
3+++ bin/ubuntuone-syncdaemon 2012-07-27 17:13:21 +0000
4@@ -48,7 +48,6 @@
5
6 from ubuntuone.platform import (
7 can_write,
8- get_filemonitor_class,
9 set_dir_readwrite,
10 is_already_running,
11 is_root,
12@@ -57,6 +56,10 @@
13 recursive_move,
14 set_application_name,
15 )
16+from ubuntuone.platform.filesystem_notifications.monitor import (
17+ get_filemonitor_class,
18+)
19+
20 from ubuntuone.syncdaemon import logger, config
21 from ubuntuone.syncdaemon.config import (
22 get_config_files,
23
24=== modified file 'tests/syncdaemon/test_eventqueue.py'
25--- tests/syncdaemon/test_eventqueue.py 2012-07-17 13:53:12 +0000
26+++ tests/syncdaemon/test_eventqueue.py 2012-07-27 17:13:21 +0000
27@@ -37,7 +37,7 @@
28 from twisted.trial.unittest import TestCase
29
30 from contrib.testing.testcase import BaseTwistedTestCase, FakeVolumeManager
31-from ubuntuone.platform import FilesystemMonitor
32+from ubuntuone.platform.filesystem_notifications.monitor import FilesystemMonitor
33 from ubuntuone.syncdaemon import (
34 event_queue,
35 filesystem_manager,
36
37=== modified file 'ubuntuone/platform/__init__.py'
38--- ubuntuone/platform/__init__.py 2012-07-17 13:53:12 +0000
39+++ ubuntuone/platform/__init__.py 2012-07-27 17:13:21 +0000
40@@ -101,12 +101,6 @@
41 stat_path = os_helper.stat_path
42 walk = os_helper.walk
43
44-# From Monitor
45-from ubuntuone.platform.filesystem_notifications import monitor
46-
47-get_filemonitor_class = monitor.get_filemonitor_class
48-FilesystemMonitor = monitor.FilesystemMonitor
49-
50 # From Logger
51 setup_filesystem_logging = logger.setup_filesystem_logging
52 get_filesystem_logger = logger.get_filesystem_logger
53
54=== modified file 'ubuntuone/platform/filesystem_notifications/__init__.py'
55--- ubuntuone/platform/filesystem_notifications/__init__.py 2012-07-17 10:51:43 +0000
56+++ ubuntuone/platform/filesystem_notifications/__init__.py 2012-07-27 17:13:21 +0000
57@@ -29,10 +29,7 @@
58 """File System Notification module."""
59
60 from ubuntuone.platform.filesystem_notifications import (
61- monitor,
62 notify_processor,
63 )
64
65 _GeneralINotifyProcessor = notify_processor.NotifyProcessor
66-FilesystemMonitor = monitor.FilesystemMonitor
67-get_filemonitor_class = monitor.get_filemonitor_class
68
69=== modified file 'ubuntuone/syncdaemon/event_queue.py'
70--- ubuntuone/syncdaemon/event_queue.py 2012-07-12 16:04:44 +0000
71+++ ubuntuone/syncdaemon/event_queue.py 2012-07-27 17:13:21 +0000
72@@ -38,7 +38,7 @@
73 from twisted.internet import defer
74
75 from ubuntuone.platform.os_helper import access
76-from ubuntuone.platform.filesystem_notifications import FilesystemMonitor
77+from ubuntuone.platform.filesystem_notifications.monitor import FilesystemMonitor
78
79 # these are our internal events, what is inserted into the whole system
80 EVENTS = {

Subscribers

People subscribed via source and target branches